The problem with the table is solved.
We worked with version 3.2.1.
The version 3.2.2, make a table no longer in a p tag.
With an hr or div tag, the problem still.
Has anyone this problem?
We are grateful for any response.
Fabio Di Vito

We will probably fix the HR issue soon. Divs on the other hand can contain or be contained in anything.

Yes, you can but it's tricky. You need to split the target paragraph first and insert the new one in the middle.

Hi, I seem to have a related problem : when I insert a template, the editor wraps my DIV in a P.

spocke wrote:

We will probably fix the HR issue soon. Divs on the other hand can contain or be contained in anything.

i checked that on the http://validator.w3.org/check (XHTML1.0 Transitional) and it tells me that there is an error when a DIV is inside a P.

Do you think the good solution is to use :
tinyMCE.init({    forced_root_block : false,    force_br_newlines : true,    force_p_newlines : false }); ??

Thank you

Vincent

Yeah the paragraph tags around the HR is a huge problem with clients, I didn't have a lot of time to fix the issue properly so I just made a quick fix that works for us. Here's how I solved it: I edited the tiny_mce.js file:

I found the method that inserts a blockquote. Grab the code inside this method and put it inside the method that inserts an HR. Now, in your new HR method change all references from BLOCKQUOTE to HR. Then near the end of the method where you see this comment:

// Add non BQ element to BQ
bq.appendChild(dom.remove(e));

change to:

// Add non BQ element to BQ
e.parentNode.insertBefore(e, bq);

This will insert an HR tag after the paragraph the cursor is in! Problem solved.

To clarify the problem and solution, take a look at this:

A client would type in a paragraph and insert an hr, the resulting HTML would look like this:

<p>This is my happy paragraph of text.</p><p><hr />Some new text.</p>

Which is annoying, but really really annoying when the client saves the data and it turns into this:

<p>This is my happy paragraph of text.</p><p></p><hr /><p></p><p>Some new text.</p>

Lots of new spaces, and the client goes berserk.

With my fix it will ensure that the HR is inserted outside of any paragraph tag, and there are no more surprises when the client saves the content.

Last edited by WYSIWTF (2009-04-15 06:07:10)

I finally figured out how to sniper out a specifically selected node (such as a pesky paragraphs) with this code:

ed.addButton('removenode', {
                  title : 'Remove This Node',
                  image : '/jscripts/remove_this_node.gif',
                  onclick : function() { ed.dom.remove(ed.selection.getNode(),true); }
              });

But the path bar (theme_advanced_path_location) doesn't get refreshed until I click away.   What method call can I use to refresh it?

Thanks,
-eric

Hi everyone, I have a very similar problem, to reproduce, start with a clean editor, type something, select text and change formatting, click somewhere in the text and insert a hr, the editor generates this code:

<p><span style="font-family: Courier New;">hello w
<hr />
orld</span></p>

anyone has a hint on how to solve this? I'm aiming at something like this:

<p><span style="font-family: Courier New;">hello w</span>
<hr />
<span style="font-family: Courier New;">orld</span></p>

or like this:

<p><span style="font-family: Courier New;">hello w</span></p>
<hr />
<p><span style="font-family: Courier New;">orld</span></p>

the generated html won't display correctly on safari/chrome.

Thanks!

Hi, I found that the table plugin inserted the table correctly, closing span tags and the current paragraph, inserting the table and opening another paragraph and span with the previous styles.
So, I stole part of the code from there and modified the advanced hr plugin:
plugins/advhr/js/rule.js

var AdvHRDialog = {
    init : function(ed) {
        var dom = ed.dom, f = document.forms[0], n = ed.selection.getNode(), w;

        w = dom.getAttrib(n, 'width');
        // by juan, changed to 100 default.
        f.width.value = w ? parseInt(w) : (dom.getStyle('width') || '100');
        f.size.value = dom.getAttrib(n, 'size') || parseInt(dom.getStyle('height')) || '';
        f.noshade.checked = !!dom.getAttrib(n, 'noshade') || !!dom.getStyle('border-width');
        // by juan, changed to % by default
        selectByValue(f, 'width2', w.indexOf('px') != -1 ? 'px' : '%');
    },

    update : function() {
        var ed = tinyMCEPopup.editor, h, f = document.forms[0], st = '';

        h = '<hr';

        if (f.size.value) {
            h += ' size="' + f.size.value + '"';
            st += ' height:' + f.size.value + 'px;';
        }

        if (f.width.value) {
            h += ' width="' + f.width.value + (f.width2.value == '%' ? '%' : '') + '"';
            st += ' width:' + f.width.value + (f.width2.value == '%' ? '%' : 'px') + ';';
        }

        if (f.noshade.checked) {
            h += ' noshade="noshade"';
            st += ' border-width: 1px; border-style: solid; border-color: #CCCCCC; color: #ffffff;';
        }

        if (ed.settings.inline_styles)
            h += ' style="' + tinymce.trim(st) + '"';

        h += ' />';




        // added by juan (borrowed from table plugin)
        var bm = ed.selection.getBookmark(), patt = '';

        ed.execCommand('mceInsertContent', false, '<br class="_mce_marker" />');

        tinymce.each('h1,h2,h3,h4,h5,h6,p'.split(','), function(n) {
            if (patt)
                patt += ',';

            patt += n + ' ._mce_marker';
        });

        tinymce.each(ed.dom.select(patt), function(n) {
            ed.dom.split(ed.dom.getParent(n, 'h1,h2,h3,h4,h5,h6,p'), n);
        });

        ed.dom.setOuterHTML(ed.dom.select('._mce_marker')[0], h);
        ed.selection.moveToBookmark(bm);
        ed.addVisual();
        // end added by juan



        //ed.execCommand("mceInsertContent", false, h);
        tinyMCEPopup.close();
    }
};

tinyMCEPopup.requireLangPack();
tinyMCEPopup.onInit.add(AdvHRDialog.init, AdvHRDialog);

I also changed the default values to 100%, I wanted it to behave more similar to the standard hr button.
It's not very well tested right now but it seems to work fine.

i am working on umbraco 4 and i am currently running into this issue.  The client wants to be able to insert and move around lots of pieces at different times and one of those pieces is a horizontal rule and it would be a lot better for them to be able to use the button rather than inserting a macro that has a horizontal rule on it (sometimes they want a separator, sometimes they don't depending on how they feel the content runs between macros and paragraphs)

is there any update that i have to download to get this fix or is the official fix not available yet?

its weird... i did some more testing and here is what i found so far

it works if you click the insert HR button in IE (although it will add an empty paragraph tag after it sometimes) and save and publish.
and it works if you click the insert HR button in firefox and then click the HTML editor and then click to update and save and publish.

but it doesnt work if you are in firefox and you just click the insert HR button and then immediately click to save and publish, that is when the HR gets removed.

Last edited by mfeola (2010-02-05 17:06:27)